Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-14025] Remove pathlib.PurePosixPath from API schemas #41

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Apr 19, 2024

Change Summary

SQLAlchemy cannot serialize JSON field with PurePosixPath field. Replace it with just string.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Apr 19, 2024
@dolfinus dolfinus force-pushed the bugfix/eliminate-purepath-from-schema branch from b1c3443 to 57d305a Compare April 19, 2024 13:15
@dolfinus dolfinus force-pushed the bugfix/eliminate-purepath-from-schema branch from 57d305a to dce279f Compare April 19, 2024 13:29
@dolfinus dolfinus force-pushed the bugfix/eliminate-purepath-from-schema branch from dce279f to 18491e6 Compare April 19, 2024 13:36
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (3932c3c) to head (64e2290).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
- Coverage    91.73%   91.72%   -0.02%     
===========================================
  Files           84       83       -1     
  Lines         2445     2441       -4     
  Branches       305      309       +4     
===========================================
- Hits          2243     2239       -4     
  Misses         145      145              
  Partials        57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus force-pushed the bugfix/eliminate-purepath-from-schema branch from 18491e6 to 64e2290 Compare April 19, 2024 18:28
@dolfinus dolfinus merged commit 1395655 into develop Apr 22, 2024
17 checks passed
@dolfinus dolfinus deleted the bugfix/eliminate-purepath-from-schema branch April 22, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants